Skip to content

test: use raw core index-update for the tests #2062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2023
Merged

test: use raw core index-update for the tests #2062

merged 1 commit into from
May 12, 2023

Conversation

kittaakos
Copy link
Contributor

Motivation

It should make integration tests more resilient on the Windows CI.

From now on, tests are not starting a daemon to initialize the directories.data folder for the test suites but rely on the raw command. It is required to avoid spawning the discovery processes, which cannot be terminated on Windows while the daemon is up and running.

Steps to verify (probably not possible as the review 😕):

  • I expect no flaky integration tests on the Windows CI.
  • The nightly builds should get back to normal.

Change description

Other information

Closes #2059

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

test: use raw core index-update for the tests
fdfc7e0 
It should make integration tests more resilient on the Windows CI.

From now on, tests are not starting a daemon to initialize the
`directories.data` folder for the test suites but rely on the raw
command. It is required to avoid spawning the discovery processes, which
cannot be terminated on Windows while the daemon is up and running.

Closes #2059

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels May 11, 2023
@kittaakos kittaakos self-assigned this May 11, 2023
@kittaakos kittaakos requested a review from AlbyIanna May 11, 2023 08:41
AlbyIanna
AlbyIanna approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@AlbyIanna AlbyIanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not really possible to test this, but the code looks good to me 👍

@kittaakos
Copy link
Contributor Author

kittaakos commented May 12, 2023 •
edited
Loading

It's not really possible to test this, but the code looks good to me 👍

Thanks! I will keep an eye on the nightly builds. If the scheduled builds are back, we have fixed the problem.

  1. https://github.com/arduino/arduino-ide/actions/runs/4964767692:

    Screen Shot 2023-05-13 at 12 47 17

  2. A few more green scheduled builds:
    Screen Shot 2023-05-16 at 10 54 33

@kittaakos kittaakos merged commit 31deeeb into main May 12, 2023
@kittaakos kittaakos deleted the #2059 branch May 12, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlbyIanna AlbyIanna AlbyIanna approved these changes

Assignees

@kittaakos kittaakos

Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[dev] Make the gRPC client init test more resilient on Windows
2 participants
@kittaakos @AlbyIanna